3D viewer : In raytracing mode, the 3D model is displayed incorrectly

Description

3D model is displayed incorrectly

Steps to reproduce

1.Open a PCB.kicad_pcb 2.Open 3D viewer 3.Enter ray trace mode 4.You can see that the model is displayed incorrectly

KiCad Version

Application: KiCad 3D 查看器 (64-bit)

Version: (5.99.0-13185-g0dcbfa2b69), release build

Libraries:
	wxWidgets 3.1.5
	libcurl/7.78.0-DEV Schannel zlib/1.2.11

Platform: Windows 10 (build 19041), 64-bit edition, 64 bit, Little endian, wxMSW

Build Info:
	Date: Nov  9 2021 12:00:58
	wxWidgets: 3.1.5 (wchar_t,wx containers)
	Boost: 1.76.0
	OCC: 7.5.0
	Curl: 7.78.0-DEV
	ngspice: 35
	Compiler: Visual C++ 1929 without C++ ABI

Build settings:
	KICAD_USE_OCC=ON
	KICAD_SPICE=ON

Please attach a project and model that shows this behavior. Also attach a screenshot that shows the correct and incorrect displays

Sorry, this project is a commercial project of our company and cannot be made public. The following is a screenshot showing the error. This problem did not occur in the previous November version of kicad 5.99

If you can reduce the project to just a minimum copy that shows the issue (just an outline and the broken footprint+model?) That could work

added statusneed-info label and removed statusnew label

I guess this bug is the same as the bug I reported, but it has been reported for two months and no one has fixed it #9416 (closed)

Confirmed with

Application: KiCad (64-bit)

Version: (6.0.0-rc1-122-g65fc47cb8f), release build

Libraries:
	wxWidgets 3.1.5
	libcurl/7.78.0-DEV Schannel zlib/1.2.11

Platform: Windows 10 (build 22000), 64-bit edition, 64 bit, Little endian, wxMSW

Build Info:
	Date: Nov 23 2021 12:00:19
	wxWidgets: 3.1.5 (wchar_t,wx containers)
	Boost: 1.76.0
	OCC: 7.5.0
	Curl: 7.78.0-DEV
	ngspice: 35
	Compiler: Visual C++ 1929 without C++ ABI

Build settings:
	KICAD_USE_OCC=ON
	KICAD_SPICE=ON

3dViewer_Render_Error.zip

I had a peek at the uploaded project, but the 3D models that do not render properly are not standard and are also not part of the project.

The location of these missing footprints are the same as the directories for the default. Apparenly these non-standard footprints have been copied into the default libraries.

I confirm:

Practically the problem occurs in almost all cases on models designed by me or downloaded.

Do the footprints in question have two (2) 3D models defined? One .step and one .wrl with the same filename?

If so, IIRC when rendering .step files, KiCad looks for .wrl file with the same filename, and renders .wrl. When you explicitly define two 3D models, KiCad will render the same .wrl 3D model which leads to artifacts.

The official library definesonly .wrl model within the footprint even though both 3D models (.wrl and .step) are required by KLC.

No, there's only one, and some models lose their color and turn gray

Yeah, I should have checked all the .kicad_pcb file contents. I read the discussion at https://forum.kicad.info/t/nightly-rendering-problem/32288 to hastily. Sorry for the noise

In my case: no. Only STEP.

In my case just .step

project with included 3D.stp-files attached: 3D_raytracing_bug.zip

Original Files downloaded from manufacturer (Würth/JST), no additional editing from my side

I confirm, the same on my kicad with project from zip file in this post:

Application: KiCad PCB Editor (64-bit)

Version: (6.0.0-rc1-277-g3c0b10b022), release build

Libraries:
	wxWidgets 3.1.5
	libcurl/7.78.0-DEV Schannel zlib/1.2.11

Platform: Windows 10 (build 19042), 64-bit edition, 64 bit, Little endian, wxMSW

Build Info:
	Date: Dec  1 2021 12:00:04
	wxWidgets: 3.1.5 (wchar_t,wx containers)
	Boost: 1.76.0
	OCC: 7.5.0
	Curl: 7.78.0-DEV
	ngspice: 35
	Compiler: Visual C++ 1929 without C++ ABI

Build settings:
	KICAD_USE_OCC=ON
	KICAD_SPICE=ON

Wow, so it was a bug after all! And I thought that I had a problem with my STEP model!

added 3d-viewer prioritymedium statusconfirmed labels and removed priorityundecided statusneed-info labels

changed milestone to %6.0.0

It turns out that this is from e81b516a

This is fixed by removing the color search from processFace() This would suggest that the face colors fetched are incorrect and overlapping the underlying solid

Was the problem fixed together？ #9416 (closed)

@sethhillbrand @mroszko is one of you taking this one on?

This is a duplicate of #9416 (closed)

@mroszko Is this something you can take? I'm not quite up to speed on the label-based changes implemented here yet

I have not been able to identify a deficiency in the label navigating. No duplication is occuring. It can be possible I broke the scene graph tree or something though....if only there were tooling for that

The coloring for faces is still legacy and is causing the problem. Do you see anything there that could be updated to the label-hierarchy?

The label hierarchy should have no impact here.

It searches for the label based on the object, then gets the color for that label

Yes? But it's clearly applying color correctly to faces in non ray tracing.

Which is why I think the scene graph may be broken from my changes. Not the color parsing.

@mroszko Here is an example where colors are not applied correctly in non ray tracing: #10554 (closed).

added regression label

mentioned in commit sethhillbrand/kicad@0085739e

mentioned in commit sethhillbrand/kicad@470fbf54

mentioned in merge request !1051 (closed)

changed milestone to %6.0.1

changed milestone to %6.0.0

changed milestone to %6.0.1

mentioned in commit sethhillbrand/kicad@8b431a05