Double-clicking launch icon segfaults

Description

When accidentally double-clicking the launch icon for eeschema in KiCad, I encounter a segfault in Linux. Note that this only happens if the second click happens prior to the Eeschema window being realized.

backtrace.txt

Steps to reproduce

1. Start KiCad
2. Double-click the Eeschema icon

KiCad Version

Application: KiCad
Version: (5.99.0-656-g2321da702), debug build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.64.0 OpenSSL/1.1.1d zlib/1.2.11 libidn2/2.0.5 libpsl/0.20.2 (+libidn2/2.0.5) libssh2/1.8.0 nghttp2/1.36.0 librtmp/2.3
Platform: Linux 4.19.0-6-amd64 x86_64, 64 bit, Little endian, wxGTK
Build Info:
    Build date: Jan  7 2020 12:02:48
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8) GTK+ 3.24
    Boost: 1.67.0
    OpenCASCADE Technology: 7.3.0
    Curl: 7.64.0
    Compiler: Clang 9.0.1 with C++ ABI 1002

Build settings:
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=ON
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=OFF
    KICAD_USE_OCC=ON
    KICAD_SPICE=ON
    KICAD_STDLIB_DEBUG=ON
    KICAD_SANITIZE=OFF

added priorityundecided statusnew labels

Just 6.0 or 5.1 as well? I cannot replicate on macOS.

changed milestone to %6.0.0-rc1

added prioritycritical label and removed priorityundecided label

Trying many times it crashed only once (I was not able to reproduce it in a deterministic way and in that case I was also dragging the project manager window)

Version: (5.99.0-777-ga2c64cdec), release build
Libraries:
    wxWidgets 3.0.2
    libcurl/7.52.1 GnuTLS/3.5.8 zlib/1.2.8 libidn2/0.16 libpsl/0.17.0 (+libidn2/0.16) libssh2/1.7.0 nghttp2/1.18.1 librtmp/2.3
Platform: Linux 4.9.0-8-amd64 x86_64, 64 bit, Little endian, wxGTK
Build Info:
    Build date: Jan 20 2020 07:21:00
    wxWidgets: 3.0.2 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24
    Boost: 1.69.0
    OpenCASCADE Community Edition: 6.8.0
    Curl: 7.52.1
    Compiler: GCC 6.3.0 with C++ ABI 1010

Build settings:
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

Thanks. I'm actually surprised that you were able to recreate on a Release build. It appears that there is a timing issue that is more pronounced when the launch is slower. Maybe dragging the window slowed it down a bit?

Yes, may be, but also I did "slow down" the system launching a "make -j8" (every core was almost at 100% load according to the system monitor) during the tests. (under light system load I was not able to see the issue, and even under heavy load I've seen it only once so may be it whas this timing issue or another "ghost bug" walking around in the code).

I think I've found a way to reproduce the issue quite reliable (current master, haven't tested it with 5.1 yet): Double-click (fast) the EEschema icon but keep the mouse button of the 2nd click pressed until EEschema opens.

With a debug build it crashes for me most of the time, with a release build I'm only able to reproduce it sometimes and only with valgrind attached

added statusconfirmed label and removed statusnew label

marked this issue as related to #4284 (closed)

mentioned in commit 5b47d1a9

closed via commit 916d06c1

added project-manager label