Dimension switches from mm in version 5 to in in version 7

Description

The units of dimension of a Pcbnew 5 file switch to non-metric when opened in KiCad 7.

Steps to reproduce

• Create test.kicad_pcb file in Pcbnew 5
• Add a dimension measurment
• Set it to mm, remove the unit mm from the text ( 10.000 mm => 10.000mm )
• Save the PCB and close Pcbnew 5
• Open test.kicad_pcb in KiCad 7
• The dimension unit is now non-metric, with the symbol in. When opened the unit "Zoll" is selected.

Pcbnew 5:

KiCad 7:

Testfile: test.kicad_pcb

I would expect KiCad to keep using mm.

After checking the *.kicad_pcb file, i saw that there is no unit information. But then there is the question why choose a non-metric "unit"? Why not automatic or mm?

KiCad Version

Application: KiCad PCB Editor

Version: (7.0.0-dirty), release build

Libraries:
	wxWidgets 3.0.5
	FreeType 2.10.4
	HarfBuzz 2.7.4
	FontConfig 2.13.1
	libcurl/7.74.0 GnuTLS/3.7.1 zlib/1.2.11 brotli/1.0.9 libidn2/2.3.0 libpsl/0.21.0 (+libidn2/2.3.0) libssh2/1.9.0 nghttp2/1.43.0 librtmp/2.3

Platform: Debian GNU/Linux 11 (bullseye), 64 bit, Little endian, wxGTK, lightdm-xsession, x11

Build Info:
	Date: Feb 24 2023 11:03:34
	wxWidgets: 3.0.5 (wchar_t,wx containers,compatible with 2.8) GTK+ 3.24
	Boost: 1.74.0
	OCC: 7.5.1
	Curl: 7.74.0
	ngspice: 34
	Compiler: GCC 10.2.1 with C++ ABI 1014

Build settings:
	KICAD_SPICE=ON

added 7.0 priorityundecided statusnew labels

changed title from Dimension switches from mm in version 5 to in in version 6 to Dimension switches from mm in version 5 to in in version 7

changed the description

changed the description

This is one change it will work. But i don't know what side effects it has.

diff --git a/pcbnew/plugins/kicad/pcb_parser.cpp b/pcbnew/plugins/kicad/pcb_parser.cpp
index b367a8d8c1..40d521c4a5 100644
--- a/pcbnew/plugins/kicad/pcb_parser.cpp
+++ b/pcbnew/plugins/kicad/pcb_parser.cpp
@@ -3226,7 +3226,7 @@ PCB_DIMENSION_BASE* PCB_PARSER::parseDIMENSION( BOARD_ITEM* aParent, bool aInFP
 
             if( isLegacyDimension )
             {
-                EDA_UNITS units   = EDA_UNITS::INCHES;
+                EDA_UNITS units   = EDA_UNITS::MILLIMETRES;
                 EDA_UNIT_UTILS::FetchUnitsFromString( text->GetText(), units );
                 dim->SetUnits( units );
             }

This will work better. It will use the same unit as before when the unit text is still there but set the unit to automatic when it couldn't be determined.

diff --git a/common/eda_units.cpp b/common/eda_units.cpp
index f6623be6f5..f87fb2a23b 100644
--- a/common/eda_units.cpp
+++ b/common/eda_units.cpp
@@ -65,7 +65,7 @@ int EDA_UNIT_UTILS::Mils2mm( double aVal )
 }
 
 
-void EDA_UNIT_UTILS::FetchUnitsFromString( const wxString& aTextValue, EDA_UNITS& aUnits )
+bool EDA_UNIT_UTILS::FetchUnitsFromString( const wxString& aTextValue, EDA_UNITS& aUnits )
 {
     wxString buf( aTextValue.Strip( wxString::both ) );
     unsigned brk_point = 0;
@@ -92,6 +92,9 @@ void EDA_UNIT_UTILS::FetchUnitsFromString( const wxString& aTextValue, EDA_UNITS
         aUnits = EDA_UNITS::INCHES;
     else if( unit == wxT( "de" ) || unit == wxT( "ra" ) ) // "deg" or "rad"
         aUnits = EDA_UNITS::DEGREES;
+    else  //No unit given.
+        return false;
+    return true;
 }
 
 
diff --git a/include/eda_units.h b/include/eda_units.h
index 75e4642151..d7d920afb1 100644
--- a/include/eda_units.h
+++ b/include/eda_units.h
@@ -67,8 +67,9 @@ namespace EDA_UNIT_UTILS
 
     /**
      * Writes any unit info found in the string to aUnits.
+     * @return true when unit was found, false when unit could not be determined
      */
-    void FetchUnitsFromString( const wxString& aTextValue, EDA_UNITS& aUnits );
+    bool FetchUnitsFromString( const wxString& aTextValue, EDA_UNITS& aUnits );
 
     /**
      * Get the units string for a given units type.
diff --git a/pcbnew/plugins/kicad/pcb_parser.cpp b/pcbnew/plugins/kicad/pcb_parser.cpp
index b367a8d8c1..573fad6c54 100644
--- a/pcbnew/plugins/kicad/pcb_parser.cpp
+++ b/pcbnew/plugins/kicad/pcb_parser.cpp
@@ -3226,8 +3226,12 @@ PCB_DIMENSION_BASE* PCB_PARSER::parseDIMENSION( BOARD_ITEM* aParent, bool aInFP
 
             if( isLegacyDimension )
             {
-                EDA_UNITS units   = EDA_UNITS::INCHES;
-                EDA_UNIT_UTILS::FetchUnitsFromString( text->GetText(), units );
+                EDA_UNITS units   = EDA_UNITS::MILLIMETRES;
+                if(!EDA_UNIT_UTILS::FetchUnitsFromString( text->GetText(), units ))
+                {
+                    //Use automatic units when unit couldn't be determined
+                    dim->SetAutoUnits(true);
+                }
                 dim->SetUnits( units );
             }
 

I will probably create a MR.

mentioned in merge request !1539 (merged)

closed with merge request !1539 (merged)

assigned to @johannespfister

added statusfix-committed label and removed statusnew label

changed milestone to %8.0

added needs-cherry-pick label

changed milestone to %7.0.1

removed needs-cherry-pick label