eeschema: possibility to save to library despite used button "Edit symbol..."
Description
The "symbol properties" dialog in eeschema contains two buttons to modify symbols:
- "Edit library symbol..." opens the complete symbol editor with the complete library-tree and allows the modifying of the symbol directly in the library. These changes remain in the library and must be reimported into the schematic with "update symbols"
- "Edit symbol..." opens the symbol editor with the info-message "Editing symbol xxx from schematic. Saving will update the schematic only". This allows symbol-modifications without affecting the original library.
Normally the second choice "Edit symbol..." should not write to the library. But if the user has opened the symbol editor at a previous point the program-flow shows an additionally "SAVE"-window and allows to write to the library. This is inconsistant behaviour (I think it should either write always or write never to the library, but not only under some circumstances)
affects: v6.0 / v6.99
Steps to reproduce
open attached project, open schematic, there are symbols prepared with included project-specific library. normal behaviour:
- doubleclick IC1, get "symbol properties" dialog
- doubleclick "Edit Symbol ..." - button --> library-editor opens (according to info-message: only for this symbol, no library editing)
- modify some item (only to get the "modified" state)
- close symbol-editor: you get the question-window: "Save changes to IC1 before closing?". choose NO
- symbol editor closes, back to schematic, all ok
different behaviour:
- doubleclick IC1, get "symbol properties" dialog
- doubleclick "Edit Library Symbol ..." - button --> library-editor opens with all libraries and with LMR16006 (IC1) open
- directly close symbol editor
now we repeat steps 1...5 , but with different result:
- doubleclick IC1, get "symbol properties" dialog
- doubleclick "Edit Symbol ..." - button --> library-editor opens (according to info-message: only for this symbol, no library editing)
- modify some item (only to get the "modified" state)
- close symbol-editor: you get the question-window: "Save changes to IC1 before closing?". choose NO
- As opposed to step 5 you get an additional question "Save changes to testlibrary before closing?" If clicking YES the changes are saved directly to the library, despite the info-message from step10 and despite the user selected deliberately the button "Edit symbol..." in step10
KiCad Version
Application: KiCad Schematic Editor (64-bit)
Version: (6.0.1), release build
Libraries:
wxWidgets 3.1.5
Platform: Windows 10 (build 19043), 64-bit edition, 64 bit, Little endian, wxMSW
wxWidgets: 3.1.5 (wchar_t,wx containers)
Boost: 1.76.0
OCC: 7.5.0
Curl: 7.78.0-DEV
ngspice: 35
Compiler: Visual C++ 1929 without C++ ABI
Build settings:
KICAD_USE_OCC=ON
KICAD_SPICE=ON