Skip to content
Snippets Groups Projects
Commit 938645b2 authored by Seth Hillbrand's avatar Seth Hillbrand 🇮🇱
Browse files

Add terrible hack to get subgraph netname 

In certain cases, the subgraph does not receive the proper netname,
preventing us from checking for correct pin counts.  This is a backwards
iteration of the net name <-> subgraph map to extract the proper name
and sibling subgraphs

Fixes #12165

Fixes #12814
parent 50ecb5b4
No related branches found
No related tags found
Pipeline #701418390 passed
Stage: build
Stage: test
Stage: report
Hide whitespace changes
Inline Side-by-side
  • Seth Hillbrand 🇮🇱 @sethhillbrand

    mentioned in issue #10338 (closed)

     ·

    mentioned in issue #10338 (closed)

    Toggle commit list
  • Jon Evans 🚲 @craftyjon ·
    Owner

    @sethhillbrand I haven't studied this closely but it seems kind of dangerous to me. m_net_name_to_subgraphs_map is a global, which is fine because it was originally storing resolved net names, which are globally unique. But now you are removing the code that ensures that only the final resolved name lives there, which means that there is the potential for conflicting unresolved net names to try to get into the map.

  • Seth Hillbrand 🇮🇱 @sethhillbrand ·
    Author Owner

    Yeah, that was a mistake leaving a debugging comment in. See df79724133e6ec4c50f51e02f90af2ce997f0c5d

  • Seth Hillbrand 🇮🇱 @sethhillbrand

    mentioned in commit 6625afab

     ·

    mentioned in commit 6625afab

    Toggle commit list
  • Jon Evans 🚲 @craftyjon ·
    Owner

    I think you haven't pushed that commit?

  • Seth Hillbrand 🇮🇱 @sethhillbrand ·
    Author Owner

    🤦 How about now (6625afab)

  • Seth Hillbrand 🇮🇱 @sethhillbrand

    mentioned in commit f6ca9806

     ·

    mentioned in commit f6ca9806

    Toggle commit list
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment