Skip to content

Fix tests suite

Arvydas Silanskas requested to merge nma.arvydas.silanskas/Kawa:testfix into master

Various changes I made to have gitlab CI testsuit runs pass, targetting java 11 LTS.

There is a generated charset file with an associated makefile rule to regenerate it. I regenerated it. However, am I understanding it right, that the charset file generation should be part of build process? It'd seem it's not picked up simply because it exists; ie maybe the file should be deleted and removed from git

I added some small api jars to testsuite folder where they were used for annotation tests.

I commented out a jaxb test because it fails without implementation available. Not sure what should be done; also add implementation jars?

The current fix for pprint seems odd (the issue was extra whitespace before newline). I didn't manage to understand why, but with a list display it appends a single space at PrettyWriter.java line 1737.

Fixed an issue regarding class annotation when using define-class caused by my older pull requests regarding adding support for parameter annotations (it caused generated class to reference a constant pool entry from parent class instead of its own). Can't say I fully understand things as it comes to these lower level compilation steps, not sure if this latest addition adequately solves everything.

Merge request reports