Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
K
Kawa
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 15
    • Issues 15
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 3
    • Merge Requests 3
  • Requirements
    • Requirements
    • List
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • kashell
  • Kawa
  • Merge Requests
  • !27

Merged
Opened Jan 11, 2021 by Arvydas Silanskas@nma.arvydas.silanskasContributor

Parameter annotations fixes

  • Overview 3
  • Commits 11
  • Pipelines 7
  • Changes 2

One change is making syntax check more lax, and only validate that following annotation declaration only other annotation declarations or opt type declaration appear (previously it was validating following annotation declaration or type declaration). It seems properly distinguishing between type declaration as part of pattern from type declaration following pattern as part of parameter syntax is tricky.

Other change is validating if any of method's parameters have annotations attached, and only create RuntimeParameterAnnotation attributes if at least one annotation is present. I'm not entirely sure what went wrong with creating it always. Perhaps it'd be worth restricting use of parameter annotations very narrowly and to only work how defined in testcase/annotations-on-parameter.scm (and not in any other lambda context) with a purpose of getting way to interop with java libs that rely on such functionality, but not chasing other edge cases, which would have dubious usability in practice.

Not sure why this pull request shows old commits

Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Reference: kashell/Kawa!27
Source branch: master