Skip to content

Simple-CDD: Show quotes in arguments when using debug mode

g0t mi1k requested to merge simple-cdd into master

Before

$ ./build.sh --debug amd64 --distribution kali-dev --installer --arch amd64
[...]
RUNNING: build-simple-cdd --verbose --debug --force-root --conf simple-cdd.conf --dist kali-dev --debian-mirror http://localhost:9999/kali/ --profiles kali offline --auto-profiles kali offline
2024-03-01 14:17:49,572 DEBUG Reading configuration...
2024-03-01 14:17:49,572 INFO Reading configuration file simple-cdd.conf
[...]

Trying to run: $ build-simple-cdd --verbose --debug --force-root --conf simple-cdd.conf --dist kali-dev --debian-mirror http://localhost:9999/kali/ --profiles kali offline --auto-profiles kali offline fails:

$ cd simple-cdd/
$ build-simple-cdd --verbose --debug --force-root --conf simple-cdd.conf --dist kali-dev --debian-mirror http://localhost:9999/kali/ --profiles kali offline --auto-profiles kali offline
usage: build-simple-cdd [-h] [--logfile LOGFILE] [--quiet] [--verbose] [--debug] [--conf CONF] [--do-mirror] [--dvd] [--no-do-mirror] [--qemu] [--mirror-only] [--build-only] [--qemu-only] [--force-root]
                        [--dist CODENAME] [--locale LOCALE] [--keyboard KEYBOARD] [--proposed-updates] [--kernel-packages KERNEL_PACKAGES] [--profiles-udeb-dist PROFILES_UDEB_DIST]
                        [--extra-udeb-dist EXTRA_UDEB_DIST] [--security-mirror SECURITY_MIRROR] [--backports-mirror BACKPORTS_MIRROR] [--profiles PROFILES] [--local-packages LOCAL_PACKAGES]
                        [--build-profiles BUILD_PROFILES] [--mirror-tools MIRROR_TOOLS] [--build-tools BUILD_TOOLS] [--auto-profiles AUTO_PROFILES] [--updates-mirror UPDATES_MIRROR]
                        [--debian-mirror DEBIAN_MIRROR] [--keyring KEYRING] [--require-optional-packages] [--force-preseed] [--serial-console]
build-simple-cdd: error: unrecognized arguments: offline offline
$

After

$ ./build.sh --debug amd64 --distribution kali-dev --installer --arch amd64
[...]
RUNNING: build-simple-cdd --verbose --debug --force-root --conf simple-cdd.conf --dist 'kali-dev' --debian-mirror 'http://localhost:9999/kali/' --profiles 'kali offline' --auto-profiles 'kali offline'
2024-03-01 14:19:13,240 DEBUG Reading configuration...
2024-03-01 14:19:13,240 INFO Reading configuration file simple-cdd.conf
[...]

Example of the command working:

$ cd simple-cdd/
$ build-simple-cdd --verbose --debug --force-root --conf simple-cdd.conf --dist 'kali-dev' --debian-mirror 'http://localhost:9999/kali/' --profiles 'kali offline' --auto-profiles 'kali offline'
2024-03-01 14:21:20,898 DEBUG Reading configuration...
2024-03-01 14:21:20,898 INFO Reading configuration file simple-cdd.conf
[...]

Merge request reports