Skip to content
  • Joonas Kylmälä's avatar
    Bug 29380: Correct table name in joins to prevent errors · 9ead0689
    Joonas Kylmälä authored and joubu's avatar joubu committed
    The commit "Bug 29290: Rename relationships borrower =>
    patron" (d46492ac
    
    ) renamed the relation for the borrowers table from
    'borrower' to 'patron' but the joins were not updated accordingly so a
    few scripts got broken.
    
    To test:
     1) Notice that
        $ perl misc/cronjobs/automatic_renewals.pl -c -s -v
        returns 255 error code on exit
     2) Apply patch
     3) Notice the automatic_renewals.pl works now and exit code is 0
     4) Make sure /cgi-bin/koha/tools/batch_extend_due_dates.pl works.
     5) Try to grep for 'borrower' in Koha source code and see if there
        are any other join done using the Koha::Checkout or
        Koha::Old::Checkout objects.
    
    Signed-off-by: default avatarDavid Nind <david@davidnind.com>
    Signed-off-by: Martin Renvoize's avatarMartin Renvoize <martin.renvoize@ptfs-europe.com>
    
    Bug 29380: (follow-up) Fix renewal feature in staff interface
    
    The commit "Bug 29290: Rename relationships borrower =>
    patron" (d46492ac
    
    ) renamed the relation for the borrowers table from
    'borrower' to 'patron' but the usage in the renew.pl script was not
    updated.
    
    To test:
     1) Try to renew a book in intranet through the renewal tab
     2) Notice it gives error
     3) Apply patch
     4) Notice the error is now gone
    
    Signed-off-by: default avatarJoonas Kylmälä <joonas.kylmala@iki.fi>
    
    Signed-off-by: default avatarJonathan Druart <jonathan.druart@bugs.koha-community.org>
    9ead0689