Skip to content
  • Petro Nugged's avatar
    Bug 29669: fix uninitialized value warnings when XSLTParse4Display is called · 81bb6761
    Petro Nugged authored and Fridolin SOMERS's avatar Fridolin SOMERS committed
    
    
    Wrong key 'xsl_filename' is present in opac-tags.pl and shelves.pl
    (the only places where it is used in the code even) instead of
    'xsl_syspref' that is actually used and this is the cause of those
    warnings.
    
    Also added honeypot to check if other calls in same way happens.
    Honeypot probably not needed, review when QA in the Community.
    
    To reproduce (shelves.pl):
    1) Prepare some test list with items or use existing one.
    2) Go to the lists page (koha/virtualshelves/shelves.pl),
    notice multitude of new warnings in the "intranet-error.log" log file
    that mostly have to do with "Use of uninitialized value $xslsyspref".
    3) Apply the patch.
    4) Go back to same page and check it again, warns like that should not
    appear in the log file anymore.
    
    To reproduce (opac-tags.pl):
    1) Go to the "my tags" page in OPAC and open "tag cloud".
    2) Notice a bunch of new warnings in the log file that mostly have to
    do with "Use of uninitialized value $xslsyspref".
    3) Apply the patch.
    4) Reload the page and check the log file again.
    
    Signed-off-by: default avatarJonathan Druart <jonathan.druart@bugs.koha-community.org>
    
    Signed-off-by: default avatarMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
    Signed-off-by: default avatarFridolin Somers <fridolin.somers@biblibre.com>
    81bb6761