Skip to content
  • Kyle M Hall's avatar
    Bug 19812: Fix confusing holds count values in "Already received" table · 36db911d
    Kyle M Hall authored and joubu's avatar joubu committed
    
    
    In acqui/parcel.pl both the "Pending orders" and "Already received" tables show how many holds there are for the given record. However, the count of holds in the "Pending orders" table confuses librarians because it only lists holds for the particular items in the orderline. Due to that, the holds column may show 0 holds even if there are a dozen record level holds for that bib! This is not what librarians seem to expect, instead it seems that the same total holds in the "Pending orders" table would be preferred.
    
    Test Plan:
    1) Find an invoice with an item in the "Already received" table
    2) Add one or more record level holds to the record
    3) Note the holds column does not count those holds
    4) Apply this patch
    5) Note the holds column now shows total holds and holds for just those ordered items
    
    Signed-off-by: default avatarKyle M Hall <kyle@bywatersolutions.com>
    
    Signed-off-by: default avatarNancy Keener <nkeener@washoecounty.us>
    
    Signed-off-by: default avatarMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
    
    Bug 19812: (QA follow-up) Swap sides for total and item holds
    
    Bug 19812: (QA follow-up) If 0 holds show '0' not '0 / 0'
    
    Bug 19812: (QA follow-up) Remove unnecessary line
    
    Signed-off-by: default avatarJonathan Druart <jonathan.druart@bugs.koha-community.org>
    36db911d