-
Steve Xuereb authored
When creating a lock create a new lock file, for example `config.toml.lock` to prevent `gitlab-runner run` process using the same config file, and fix issues for Windows where there is only exclusive locks (so no other process can even read from it). With this change we still end up allowing users using the same config file when they just mount the `config.toml` file to a Docker container since the lock file is not mounted so we loose that functionality. This is expected and is a more complex thing to fix, which a file lock is not enough, that kind of locking should happen on GitLab coordinator side. closes gitlab-org/gitlab-runner#4691 gitlab-org/gitlab-runner#4721
Steve Xuereb authoredWhen creating a lock create a new lock file, for example `config.toml.lock` to prevent `gitlab-runner run` process using the same config file, and fix issues for Windows where there is only exclusive locks (so no other process can even read from it). With this change we still end up allowing users using the same config file when they just mount the `config.toml` file to a Docker container since the lock file is not mounted so we loose that functionality. This is expected and is a more complex thing to fix, which a file lock is not enough, that kind of locking should happen on GitLab coordinator side. closes gitlab-org/gitlab-runner#4691 gitlab-org/gitlab-runner#4721
Loading