Skip to content

Fix invalid url in footer

Yukai Chou requested to merge muzimuzhi/islandoftex.gitlab.io:absolute-url into master

Currently, the text Found an error? File it or fix it here. at the bottom of https://islandoftex.gitlab.io/ links to an invalid URL

https://islandoftex.gitlab.io/https://gitlab.com/islandoftex/islandoftex.gitlab.io/

That's because the adidoks zola theme treats extra.footer.nav.url as a relative url by using zola function get_url(), hence the base_url (here https://islandoftex.gitlab.io) is always prepended. See templates/macros/footer.html in adidoks.

{% if config.extra.footer.nav %}
  {% for val in config.extra.footer.nav %}
    <li class="list-inline-item"><a href="{{ get_url(path=val.url, trailing_slash=true) | safe }}">{{ val.name }}</a></li>
  {% endfor %}
{% endif %}

This MR makes the extra.footer.nav.url treated as absolute URL, by adding a slightly modified copy of footer.html macro.

"Good" news is that adidoks seems not in active development and the last change to footer.html happened on May 3, 2021, two years ago.

Merge request reports