Signed-off-by: Nikos Mavrogiannopoulos <n.mavrogiannopoulos@gmail.com>

Signed-off-by: Nikos Mavrogiannopoulos <n.mavrogiannopoulos@gmail.com>

Resolves: #31

Signed-off-by: Nikos Mavrogiannopoulos <n.mavrogiannopoulos@gmail.com>

Signed-off-by: Nikos Mavrogiannopoulos <n.mavrogiannopoulos@gmail.com>

Signed-off-by: Nikos Mavrogiannopoulos <n.mavrogiannopoulos@gmail.com>

Fix test output on failure + shellcheck warnings

See merge request !40

Without quotes around $output, test failures will only print the first
word of the output. I.e. previously, for the erroneous output "I am not
useful :(", the following would be printed:

    Output was:
    I

Instead of:

    Output was:
    I am not useful :(

Also, change shebang from /bin/sh to /bin/bash to fix the following
shellcheck warning:

    In tests/ipcalc-testrunner.sh line 32:
      echo -e "Output was:\n$1"
                 ^-- SC3037 (warning): In POSIX sh, echo flags are undefined.

And, replace $@ with $* in strings to fix the following shellcheck
error:

    In tests/ipcalc-testrunner.sh line 36:
      echo -n "Checking $@... "
                              ^-- SC2145 (error): Argument mixes string and array. Use * or separate argument.

There were changes in fedora 39's lcov that require changes to
our usage of it.

Signed-off-by: Nikos Mavrogiannopoulos <n.mavrogiannopoulos@gmail.com>

Signed-off-by: Nikos Mavrogiannopoulos <n.mavrogiannopoulos@gmail.com>

Signed-off-by: Nikos Mavrogiannopoulos <n.mavrogiannopoulos@gmail.com>

Signed-off-by: Nikos Mavrogiannopoulos <n.mavrogiannopoulos@gmail.com>

Signed-off-by: Nikos Mavrogiannopoulos <n.mavrogiannopoulos@gmail.com>

Signed-off-by: Nikos Mavrogiannopoulos <n.mavrogiannopoulos@gmail.com>

Fix last network IP for /31 prefixes

Closes #25

See merge request !39

As info->broadcast for a /31 is 255.255.255.255, we need to change it here to correctly split a /31.

Signed-off-by: Nikos Mavrogiannopoulos <n.mavrogiannopoulos@gmail.com>

Previously when --no-decorate was given its output would
consist of a combination of "title: value" and "value" fields
which was neither human readable nor script parsable.

Resolves: #28

Signed-off-by: Nikos Mavrogiannopoulos <n.mavrogiannopoulos@gmail.com>

Signed-off-by: Nikos Mavrogiannopoulos <n.mavrogiannopoulos@gmail.com>

Signed-off-by: Nikos Mavrogiannopoulos <n.mavrogiannopoulos@gmail.com>

Signed-off-by: Nikos Mavrogiannopoulos <n.mavrogiannopoulos@gmail.com>

Signed-off-by: Nikos Mavrogiannopoulos <n.mavrogiannopoulos@gmail.com>

Fix ULA prefix generator to use only defined ULA range

Closes #27

See merge request !37

Signed-off-by: Nikos Mavrogiannopoulos <n.mavrogiannopoulos@gmail.com>

Ondřej Caletka authored 2 years ago and Nikos Mavrogiannopoulos committed 2 years ago

According to RFC 4193 the format of ULA prefix is fc00::/7 followed by L
bit which has to be set to 1 for locally assigned prefixes. The meaning
of L flag reset to zero may be defined in the future, but is now
undefined. Therefore, only defined ULA addresses are in fd00::/8 range.

Fixes #27.

Signed-off-by: Ondřej Caletka <ondrej@caletka.cz>

Ondřej Caletka authored 2 years ago and Nikos Mavrogiannopoulos committed 2 years ago

On macOS, tr -d [:space:] removes also newline. So it has to be applied
on both sides of the comparsion.

Signed-off-by: Nikos Mavrogiannopoulos <n.mavrogiannopoulos@gmail.com>

Signed-off-by: Nikos Mavrogiannopoulos <n.mavrogiannopoulos@gmail.com>

Signed-off-by: Nikos Mavrogiannopoulos <n.mavrogiannopoulos@gmail.com>

Signed-off-by: Nikos Mavrogiannopoulos <n.mavrogiannopoulos@gmail.com>

This prevents warnings from static analyzers

Signed-off-by: Nikos Mavrogiannopoulos <n.mavrogiannopoulos@gmail.com>

Signed-off-by: Nikos Mavrogiannopoulos <n.mavrogiannopoulos@gmail.com>

Don't filter redundant info from JSON output

Closes #21

See merge request !35

More info here: https://editorconfig.org/

In order to make JSON output more uniform, do not filter out info that
can be considered redundant for single host IPs.

Does not affect regular (non-JSON) output.

Before:

    $ ipcalc --json 127.0.0.1
    {
      "ADDRESS":"127.0.0.1",
      "ADDRSPACE":"Loopback"
    }

After:

    $ ipcalc --json 127.0.0.1
    {
      "ADDRESS":"127.0.0.1",
      "NETWORK":"127.0.0.1",
      "NETMASK":"255.255.255.255",
      "PREFIX":"32",
      "BROADCAST":"127.0.0.1",
      "ADDRSPACE":"Loopback",
      "MINADDR":"127.0.0.1",
      "MAXADDR":"127.0.0.1",
      "ADDRESSES":"1"
    }

fix typo in usage-message

See merge request !34

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>