Skip to content

#148 Merge measurement_lane_plot data into measurement_lane

Marko Vendelin requested to merge feature/148-drop-measurement-plot-table into feature/182-schema-revision

This drops measurement_lane_plot table and puts the relevant data into measurement_lane. MR is against feature/182-schema-revision (!114 (merged)) and should be merged into it before !114 (merged).

Right now all seems to be working except Undo of measurement lane toggling (delete) in terms of showing right side graph. To reproduce:

  • define gel, lanes, image lanes
  • in measurements, add new measurement
  • tap on measurement lanes to enable few
  • tap on lane 1 and notice disappearance of L1 in the table and plots on the right
  • tap on lane 1 and notice L1 in the table and plots on the right coming back
  • tap on lane 1 and notice disappearance of L1 in the table and plots on the right
  • press Undo

L1 comes back in the measurement table, but not in the plots on the right. @jakutt, any ideas why? Maybe it was already bug before that we missed with Undo/Redo rewrite...

Other than that, please review

Fixes #148 (closed)

Merge request reports