Fix: Cannot return to text tool from font dropdown
In Inkscape master, pressing the escape key while in the font dropdown doesn't return focus to the textbox. Modified ComboBoxEntryToolItem::defocus() to always target the active desktop's canvas, bypassing stored focus widgets that caused the current behavior.
Fixes #5581
Merge request reports
Activity
Tested in its current state: This does make esc return to text editing in the font family dropdown box, but only the font family dropdown box. I believe the right fix here is to implement our own widget for the dropdown-combobox so that it can be reused in all places. (I may be wildly wrong)
added 1 commit
- c1ffa463 - Fix: Cannot return to text tool from font dropdown
@ltlnx I have done changes in the combobox now, should be working fine now. Can you check?
-
It now works good here. There's only one problem left: When you type in a font into the font selector, then press esc, the suggestions list doesn't disappear until you type another character.
Also the canvas performance seems to have gone worse, but I'm not sure if it's your MR that's the culprit. Would have to test the current master.
287 287 _font_family_item->set_warning_cb(&sp_text_toolbox_select_cb); 288 288 _font_family_item->focus_on_click(false); 289 289 _font_family_item->connectChanged([this] { fontfamily_value_changed(); }); 290 _font_family_item->setDefocusWidget(this); 290 // _font_family_item->setDefocusWidget(this); -
@aayush01x if this MR is ready for a code review, please remove the commented out lines
