Fix toolbar memory leak

This is a fix for one (of many) LeakSanitizer-identified memory leaks, i.e. replaces a new operator (for ToolbarMenuButton) with a shared_ptr, in toolbar.cpp. Also, it makes a loop boundary constant; and makes a post-increment a pre-increment.