Skip to content

TextToolbar/ComboBoxEntryItem: Clean up code, performance, GtkBin API use, nullptr

Daniel Boles requested to merge dboles/inkscape:djb_TextToolbar_cleanups into master

Cleanups for the text toolbar, noticed when checking uses of CssProvider et al pre GTK4.

commit b347e803951da67f12a8c2303e119bef20e35bd4 (HEAD -> djb_TextToolbar_cleanups)
Author: Daniel Boles <dboles.src+inkscape@gmail.com>
Date:   Tue Sep 19 17:00:21 2023 +0100

    ComboBoxEntryToolItem: Avoid GtkBin API/uninit ptr
    
    Replace GtkBin API usage with UI::get_first_child() to be GTK4-ready.
    
    _entry would not be assigned if we didn't create one, so reading it
    would be UB. Explicitly initialise to a null pointer until otherwise.

commit a3c968f841a2506f41c41a4962b6d68d2f79272a
Author: Daniel Boles <dboles.src+inkscape@gmail.com>
Date:   Tue Sep 19 16:49:45 2023 +0100

    ComboBoxEntryToolItem: Avoid un/signed warning etc
    
    Avoid a warning about comparison among mixed-signed variables. Cleanups.

commit e0416fa2cad0e76cec6af0489297c15df241023b
Author: Daniel Boles <dboles.src+inkscape@gmail.com>
Date:   Tue Sep 19 16:04:07 2023 +0100

    Avoid copies in getting/iterating font collections

commit ee35a57a708f70b5f4b8b37f06ec7535c6b59687
Author: Daniel Boles <dboles.src+inkscape@gmail.com>
Date:   Tue Sep 19 15:50:22 2023 +0100

    TextToolbar: Remove unneeded/duplicate CssProvider
    
    style.css already provides this, and that works, without us having to
    add/leak another one here in the cpp file.
Edited by Daniel Boles

Merge request reports