Skip to content

menuize: Fix highlighting on any motion | PopoverMenu: keep own vector of items

Daniel Boles requested to merge dboles/inkscape:djb_PopoverMenu_fix_tweak into master 
commit c45ad488e78503c9f5678d1b8d463ae4ef8f1d10 (HEAD -> djb_PopoverMenu_fix_tweak)
Author: Daniel Boles <dboles.src+inkscape@gmail.com>
Date:   Wed Aug 30 10:16:51 2023 +0100

    PopoverMenu: Keep our own vector of items, so that
    
    we can check that remove() is used correctly, i.e. gets an item, not our
    internal Grid. Do so. Check it isn't removed in more add() type methods.
    Keeping an own vector also prepares for GTK4 where Widget.get_children()
    no longer exists, and it means we don't rely on its order which in some
    widgets (though not, so far, GtkGrid) is not what anyone would expect...

commit 4e9c6ec4b36e89726540cf52f9c4e6ae6187dcb4
Author: Daniel Boles <dboles.src+inkscape@gmail.com>
Date:   Wed Aug 30 10:13:15 2023 +0100

    menuize: Fix highlighting on any motion lost, as…
    
    …we do not get motion events for free on PopoverMenuItem/Gtk::Button, so
    we need to ensure we add them ourselves. Do so for the rest just in case

Merge request reports