Skip to content

GradientImage: − unnecessary Widget inherit/vfuncs | others: cleanups

Daniel Boles requested to merge dboles/inkscape:djb_GradientImage_preGTK4_cleanups into master 
commit 1b723a74c77fce55b21dccbf18f7ee42da20e521 (HEAD -> djb_GradientImage_preGTK4_cleanups)
Author: Daniel Boles <dboles.src+inkscape@gmail.com>
Date:   Wed Aug 23 13:17:59 2023 +0100

    GradientToolbar: Cosmetic cleanups & sort by label
    
    Gradients weren't sorted by label, which looked ugly. This fixes that.

commit e2d6109a79a0b143d7e3caa9fc2a4306fe2a9ec5
Author: Daniel Boles <dboles.src+inkscape@gmail.com>
Date:   Wed Aug 23 13:17:40 2023 +0100

    ComboToolItem: raw delete →unique_ptr. Move RefPtr
    
    and avoid copying/reapplying the same string if we are not modifying it!

commit 78b45343fab687a9ad5d974ad6f777c0892dd382
Author: Daniel Boles <dboles.src+inkscape@gmail.com>
Date:   Wed Aug 23 12:45:31 2023 +0100

    GradientImage: − unnecessary Widget inherit/vfuncs
    
    Rather than laboriously setting constant preferred sizes via vfuncs that
    will be renamed and tedious to migrate in GTK4, just be a Box, and set a
    minimum size in CSS instead. Clean up includes, namespaces, duplication:
    the most offensive being THREE copies of the same drawing code… now one!
    
    AFAICS this is our last direct inherit from Gtk::Widget, which is handy.

Merge request reports