Skip to content

Port node tool helper classes in ui/tool to CanvasEvents

PBS requested to merge pbs3141/inkscape:control-points into master

The node tool has an entire directory ui/tool of helper classes. This MR ports them from GdkEvent to CanvasEvent.

The only residual GdkEvent usage left in ui/tool is:

  • A call to get_latin_keyval(), which currently takes a GdkEvent.
  • The synthesis of a fake MotionEvent. Currently synthesizing fake CanvasEvents requires synthesizing a fake backing GdkEvent too.
  • A hack which uses the condition x_root == -1 to encode whether something has been cancelled. This can be sorted out by adding a user flag to CanvasEvent.

Additional fixes:

  • Removed an unintentional-looking switch fallthrough in MultiPathManipulator::event(), case GDK_KEY_D:.
  • Remove the implicit conversion of control points to Geom::Points, preferring the explicit position() function instead.
Edited by PBS

Merge request reports