Skip to content

Fix crash editing in Selectors and CSS dialog (macOS)

Nathan Lee requested to merge nathanal/inkscape:inbox7500 into master

Escape closing brace ("}") to avoid std::regex mismatched brackets (AppleClang 13.0.0.13000029).

inbox#7500 (closed)

https://en.cppreference.com/w/cpp/regex/ecmascript The relevant bit here seems to be the format of the Atom (search for AtomEscape) and IdentityEscape. I'm not sure why it didn't crash outside of macOS but at least the escaped braces should be supported

Looking at the old pipelines on this MR, you can see that without the \\, it fails on the macos tests job. Namely: b7c887ed results in failed tests, and 52d4ce4a results in passing mac tests.

Edited by Nathan Lee

Merge request reports