Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
  • inkscape inkscape
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 1,525
    • Issues 1,525
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 138
    • Merge requests 138
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • External wiki
    • External wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Inkscape
  • inkscapeinkscape
  • Merge requests
  • !3780

Do not justify the last line in a paragraph

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Martin Owens requested to merge doctormo/inkscape:fix-mid-span-new-line-justification into master Dec 30, 2021
  • Overview 0
  • Commits 1
  • Pipelines 3
  • Changes 1

In SVG 2.0 text, the manual breaks are not split between spans. So the check for manual breaks must be done when adding the justification to a line.

Because the code was already checking for end of span and single word conditions, justification of a line could happen seemingly at random if the last line in a paragraph ended up only containing one word. And change in the text would see the line's justification flip back and forth depending on how many words were on that final line.

This change shouldn't effect SVG 1.1 text since their manual breaks are encoded in separate spans and we still check for this condition.

Fixes #1661 (closed)

Before:

before

After:

after

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: fix-mid-span-new-line-justification