Skip to content
GitLab

Fix find and replace if text has description, nested tspans

Merged Nathan Lee requested to merge nathanal/inkscape:inkscape2838 into master

First commit

Text in <description> or <title> should be ignored when find and replacing text.

Fix #2838 (closed)

Mismatch between the text you find and the one you replace causes the bug in #2838 (closed)

Second commit

Fix find and replace with nested tspans

Also other fixes where sp_te_get_string_multiline(SPItem*) used,
as extra newlines/spaces were generated in this function,
compared to Layout and the other sp_te_get_string_multiline function.

#1571 (closed)

Review of places where sp_te_get_string_multiline(SPItem*) is used.

  1. Find and replace dialog: new behavior correct
  2. text-edit.cpp: New behavior correct (Text and Font dialog preview no longer adds newline for style changes
  3. GlyphsPanel::insertText in glyphs.cpp : New behavior more correct, doesn't add new lines when hitting append. The subscript is still lost in both cases though.
  4. text_unflow in text-chemistry.cpp : New behavior more correct, no added spaces with tspans
Edited by Nathan Lee