Skip to content

WIP: LPE Refactor -History Fix-. Live Path Effect System Revisited

Jabier Arraiza requested to merge LPERefactorHistoyFix into master

Bounding box is well calculated, no problem is is a group with nested subgroups, or some group or shape has more than one LPE applyed, or some element has clip or mask on it.

The goals of the LPE refactor are:

1.- Correct the bounding box calculation to apply the LPE. Is reproduced when:

  • Apply a LPE to a clip or mask with his bounding box bigger than the cliped/masked Element
  • Apply more than one LPE to the same LPE, bounding box if used in the LPE is sucesibely corrupted

2.- Allow acces to the current LPE shape in any moment of the LPE process (For future devs this is very handy, Is done previously by a commit mine but now are simplified. THe current shape is defined on apply the LPE and work for shapes, paths inside groups or standalone and clip and mask items.

3.- Allow LPE on cliped and masked shapes if the LPE allow it, also work on groups

4.- Organice functions in SP-PATH and SP-SHAPE to allow with less functions have all required curves in any moment

5.- Cleanup of shapes code to apply effect on the same way in path, ellipse, star and spiral and always in perform path effect.

6.- Refactor of the default parameter code, removing menmleaks and moving to the effect code from the LPE dialog

7.- Switch effect on efectlist change selection, with knots and helper paths

8.- Fix a transform issues that fire update path effects on groups when moving slowing the movement.

9.- Add knots for shapes when has LPE

Is a big rewrite so we need to be alert for possible regressions.

Merge request reports