Fix and Refactor spinbutton toolitem
fixes #690 (closed) and #689 (closed)
image-updated till commit b3537605 13 is not a "standard" value but is 8+5(page) while 8-5=3 is a "standard" value hence is original value and its label is preserved and value uniqueness is maintained at all times.
UI
Page up/down feature exists for fast changes, removed duplicate and out of bounds values labels preserved
Development
Optimized API for densely as well as sparsely labeled data.
Edited by Abhay Raj Singh
Merge request reports
Activity
Tasks left
- [Done] improve API
- Currently, two different vectors are used which should be of the same size, make a function that accepts a map(maybe unordered) as the second parameter to add labels makes much more sense where labels are sparse
- [Done] Improve implementation
- Currently, a
vector of pairs
is used to store menu, however,std::map
with a custom comparatorrounded values will be much better for code simplicity and maintainability.
- Currently, a
Edited by Abhay Raj Singh- [Done] improve API
@jhofinger review please
Edited by Abhay Raj Singhadded 1 commit
- 027d2318 - Using maps to store data (for uniqueness and sorting)
- Resolved by Abhay Raj Singh
- Resolved by Abhay Raj Singh
- Resolved by Abhay Raj Singh
- Resolved by Marc Jeanmougin
added 1 commit
- 081c3515 - Using emplace instead of insert, assigning defaut values in class declaration...
Please register or sign in to reply