-
Daniel Boles authored
* Replace raw pointers/new/delete with std::unique_ptr. * …NOT including SPDesktop deleting Canvas*Group @ dtor, which crashes…? * Replace public desktop, window, etc. pointers – with getters+setters. * Prefix those pointers w/ _ per coding style plus existing member vars. * Rename event_context & getEventContext() to tool & getTool() per revw. * Drop the infernal unneeded `dtw->` (copy of `this`) prefix where diff. * Remove unused (never populated) _connections and loop disconnect()ing. * Remove unused, always-false result from showInfoDialog() functions. * In inkscape-window, use make_managed(), instead of `new` and manage(); * and avoid therein an unnecessary (tautological) dynamic_cast<>() call. * Use auto_connection instead of disconnect()ing in destructors. * Avoid raw `new` and `delete`, possible leaks in desktop.* w/ UPtr too. * Avoid unnecessary use of sigc::ptr_fun when can just use function ptr. * Bin pointless setting of member pointers to nullptr during destructor. * Replace manual GestureZoom setup with new UI::Controller::add_zoom(). * Replace access to GdkEvent.button.[xy] with coords stored @ ::motion. * CanvasGrid: Let Gesture be const&. Drop unused horiz arg@ ButtonPress * various: replace GTK_WIDGET(gobj()) w Gtk::Widget::gobj(), a drive-by while I was already in `sed` mode avoids the checked cast every time. * Make ~CompletionPopup() final to fix CI clang-tidy. Ditto whole class * Add myself to AUTHORS. * Tweak CONTRIBUTING to clarify: open an MR, not push to some dev branch !5736
After you've reviewed these contribution guidelines, you'll be all set to
contribute to this project.