Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
  • extensions extensions
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 77
    • Issues 77
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 15
    • Merge requests 15
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

Scheduled maintenance on the database layer will take place on 2022-07-02. We expect GitLab.com to be unavailable for up to 2 hours starting from 06:00 UTC. Kindly follow our status page for updates and read more in our blog post.

  • Inkscape
  • extensionsextensions
  • Merge requests
  • !437

Lindenmayer / Path turtle: correct coordinate system

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Jonathan Neuhauser requested to merge joneuhauser/extensions:fix-lindenmayer-orientation into master Feb 20, 2022
  • Overview 0
  • Commits 1
  • Pipelines 2
  • Changes 5

What does the merge request do?

Fix https://bugs.launchpad.net/inkscape/+bug/1094627

For Lindenmayer, "Turn left" and "Turn right" were inverted. This was due to an error in turtle.py - the y axis in SVG looks down so a left rotation has a negative sign.

Entering the examples on Wikipedia now gives identically oriented results.

Question: can we change this behavior? turtle is used in 2 extensions in mightyscape, so it's rather rare. But it's still a breaking change without warning.

Answer: We're not changing the API, it's the API being broken. Even if users are affected, a simple Mirror command is all it takes to fix this on user side.

Implementation notes

Added unit tests for a simple Koch snowflake and a Sierpinski triangle to test multiple rules.

Summary for release notes

A bug in the rotation sense of the Lindenmayer extension has been fixed.

Checklist

  • Add unit tests (if applicable)
  • Changes to inkex/ are well documented
  • Clean merge request history
Edited Feb 20, 2022 by Jonathan Neuhauser
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: fix-lindenmayer-orientation