Skip to content

Fix pixelsnap coordinate system

Jonathan Neuhauser requested to merge joneuhauser/extensions:pixelsnap-mm into master

What does the merge request do?

Closes #264 (closed)

The pixelsnap extension aligned objects to a coordinate system starting at the bottom of the page. This is a bad default for 1.0+. A new option has been added.

The issue with incorrect unit conversions doesn't happen for me anymore and is likely fixed since !329 (merged) (haven't bisected though).

Implementation notes

The unit test is a file with a height of 297.3mm, so the difference between the two options can be seen.

The pixel snap extension features a lot of redundant code and has a bad test coverage; there are likely more bugs to be found.

Summary for release notes

The Pixel snap extension now aligns objects to the coordinate system starting at the top left of the page. The previous behavior, snapping them to a grid aligned with the page bottom, can be activated in the settings. A bug related to inconsistent unit conversion has been fixed as well.

Checklist

  • Add unit tests (if applicable)
  • Changes to inkex/ are well documented
  • Clean merge request history
Edited by Jonathan Neuhauser

Merge request reports