Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
  • extensions extensions
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 77
    • Issues 77
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 15
    • Merge requests 15
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Inkscape
  • extensionsextensions
  • Merge requests
  • !418

apply black formatting and add CI run

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Jonathan Neuhauser requested to merge joneuhauser/extensions:black-reformat into master Feb 04, 2022
  • Overview 0
  • Commits 1
  • Pipelines 1
  • Changes 403

What does the merge request do?

Apply the Black python formatter to the entire codebase, as discussed in yesterday's dev meeting. This is one giant commit, but good news, you will never see whitespace changes again :)

Also added a config for a git pre-commit hook and updated the CI to include a check for codestyle compliance.

Implementation notes

  • The maximum line length in pylintrc has been changed to 88 characters, which is what Black uses (https://black.readthedocs.io/en/stable/the_black_code_style/current_style.html).
  • I haven't used any formatting on/off switches.

Summary for release notes

The code formatting of the extensions repository has been made consistent. This enables contributors to think less about formatting and more about what matters.

Checklist

  • Add unit tests (if applicable)
  • Changes to inkex/ are well documented
  • Clean merge request history
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: black-reformat