Skip to content

Fix Range#include? being deprecated for date time ranges

Vincent Agnano requested to merge fix-deprecation-range-include into recette

Created by: n-b

@yaf est-ce que tu sais pourquoi ligne 75 on utilisait include?, mais lignes 76 et 77 on utilisait cover??

DEPRECATION WARNING: Using `Range#include?` to check the inclusion of a value in a date time range is deprecated. It is recommended to use `Range#cover?` instead of `Range#include?` to check the inclusion of a value in a date time range. (called from first_range at /Users/nicolas/Documents/rdv-solidarites.fr/app/services/slot_builder.rb:69)

DEPRECATION WARNING: Using `Range#include?` to check the inclusion of a value in a date time range is deprecated. It is recommended to use `Range#cover?` instead of `Range#include?` to check the inclusion of a value in a date time range. (called from remaining_range at /Users/nicolas/Documents/rdv-solidarites.fr/app/services/slot_builder.rb:75)

See https://github.com/rails/rails/pull/38186.

Basically, include? calls cover? under the hood when relevant, but that extension in Rails was confusing, so it’s being.

Merge request reports