Skip to content

Make ws server drop connection

Marcos Huck requested to merge fix/conn_closed into fix/race_conditions

Related tasks

Context

Once the mutex for topics was introduced, the TestTransporterListenDontPanicWSClosed test case failed, and a race condition was detected in the conn variable.

Change

  1. Remove duplicated test case: Both tests cases included the exact same test logic.
  2. Call Close from server instead of conn: This will allow us to mimic the same behavior as before but avoiding a race condition

Other information

There are still some test runs that fail with the broken pipe error on listen_test.go:39

Additional documentation

Edited by Marcos Huck

Merge request reports