Make robot names be in lowercase when uploading logs
Related tasks
Context
The worker refactor introduced a new naming convention for robot names when uploading logs to S3. They were previously named in lowercase, now they keep the same format as when the simulation was requested, the subt app is making users download robot logs in lowercase format, that's why they can't download logs, as they're differently named now.
For example:
- Original naming scheme:
94e0-fc-teambase-commsbridge.tar.gz - New naming scheme:
94e0-fc-TEAMBASE-commsbridge.tar.gz
The trade-off here is:
- Restore lowercase convention, giving access to previous simulation logs (before worker refactor), but we'll need to rename .tar.gz files for all recently created simulations.
- Enforcing the new convention to keep the same name as in the request, but we'll loose access to logs before the worker refactor was introduced, the good thing is that teams will gain immediate access to recent logs.
Change
This MR makes the GetCommsBridgeLogsFilename return the robot name in lowercase.
Other information
IMPORTANT: Recently created simulation robot logs need to match the original naming scheme.
Additional documentation
Edited by Marcos Huck