Skip to content

Add FrequencyResponse4 action

Kevin Kuns requested to merge feature/FrequencyResponse4 into develop

What does this MR do and why?

Adds the FrequencyResponse4 action which calculates transfer functions from mechanical and electrical nodes to optical nodes. This is the same as !163 (closed) but merging from a branch of this repository instead of from my fork. Note that the matrix dimensions of FrequencyResponse have been changed to the preferred [frequencies, outputs, inputs] as discussed in the comments of that MR but unlike the description there.

Name indexing is for FrequencyResponseSolution is fixed and more strict now. It requires two keys sol[A, B] for B->A or sol[A, :] for all->A, etc.

How to set up and validate locally

Run the attached script. FrequencyResponseFunctions.py

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

  • Includes tests for added/modified code
  • Added or modified the documentation if relevant
  • Docstrings added/modified for new/modified functions
  • Committer/reviewer has ran the documentation stage when ready to merge
Edited by Daniel Brown

Merge request reports