"heading-level" does not work correcly in dialogs

Closed Issue created 3 years ago by Mihkel Eidast

"heading-level" rule fails to enforce proper heading levels in dialogs. A follow-up to #92 (closed).

Reduced test-case

<!DOCTYPE html>
<html>
    <body>
        <div role="dialog">
            <h3>heading 3</h3>
        </div>
    </body>
</html>

Configuration

{
  "rules": {
    "heading-level": [
      "error",
      {
        "sectioningRoots": ["[role=\"dialog\"]"]
      }
    ]
  }
}

Expected result

I expect the example HTML to be invalid (heading level should be h1 instead of h3). Note that for the example HTML, the sectioningRoots option on the rule should not matter, I would expect it to fail even if the option is not specified.

Actual result

The example HTML is considered valid.

Version

html-validate: 4.11.0

Edited 3 years ago by Mihkel Eidast

Linked items 0

Link items together to show that they're related or that one is blocking others.