Skip to content

Refine test suite for hpcprof

Jonathon Anderson requested to merge blue42u/more-hpcprof-tests into develop

Currently, the tests/hpcprof suite tests most but not all main code paths. This MR extends it a bit to test more.

Specifically, the fallback code paths that use DirectClassification are now (kind of) tested. This requires two changes:

  • A new flag --ignore-structs is added and tested, which ignores the Structfiles in the <meas>/structs/ directory.
  • --foreign now enables DirectClassification, but changes are made elsewhere to ensure files outside the measurement directory are remapped to some path that (almost certainly) doesn't exist.

In order for this to work, we need to remap (-R) the measurement directory from it's as-recorded location to it's new location. This flag can be removed once relative paths for measurement dirs are implemented, i.e. #411 (closed)/#269 (closed)/!1087 (merged).

While in the area, add a no-change hpcprof test for the loops-hip-amd-t measurements. ROCm and CUDA are different enough that we should really test hpcprof on both cases.

Backward Compatibility

  • This MR does not alter the data formats.
  • This MR only adds CLI options.

Additional Information

This MR is meant as a precursor to !1087 (merged) that adds the test cases needed to properly test that MR.

Checklist

  • I have run pre-commit run -a on my local checkout and fixed any reported issues.
  • I have confirmed that existing tests and/or the tests added by this MR cover the changes introduced by this MR.
  • I have confirmed that any added tests will be automatically run in CI.
  • I have updated all relevant documentation:
    • The --help text for the tools
Edited by Jonathon Anderson

Merge request reports