Skip to content

Address 2D binning gaps/booking errors from attempted edge-uniqueness filtering

Andy Buckley requested to merge axis2d-uniqueness-fix into release-1-9-x

The Axis2D class imposes a well-meaning but problematic comparison of bin edges, with a fuzziness based on the median bin width, in an attempt to filter out numerical-precision near-misses between adjacent-bins' touching edges.

The patch currently changes the Axis2D edge-uniqueness test to be based on the smallest bin width rather than the median, which is far safer for log binning with large ranges.

Still smarter could be to compare with the smallest of the surrounding bin widths. Or drop entirely, as 1D doesn't seem to have real problems with numerical near-matches...?

Edited by Andy Buckley

Merge request reports