Skip to content

Include all bytes in MidiMessage when sending

James OB Fisher requested to merge jamesobfisher/grig.midi:feature/sysex-messaging into main

These commits make it so that sysex messages can be sent.

Previously when sending a midi message, only the first 3 bytes were accounted for.

The commit [ jamesobfisher/grig.midi@c28c194c ] makes it so that byte3 is always the final byte, as that seemed to be what you had in mind.

The commit [ jamesobfisher/grig.midi@0447ec24 ] adds all the inner bytes rather than just byte2 when handling SysEx. Though the check for if it is messageType of SysEx may be unnecessary and instead could always do the for loop?

for(i in 1...message.length - 1){
  messageArray.push(message.get(i));
}

I wonder if rather than using byte1, byte2, byte3 it might instead be beneficial for them to be named something like first, inner, final?

Merge request reports