Skip to content

Fix segfaults and resultwhen using remote-connect on detached remotes.

Maxime Devos requested to merge emixa-d/guile-git:master into master

  • Big-endian architectures exist, the assumption ‘size_t is big-endian’ is incorrect in the general case

  • an incorrect offset was used for the oid/loid (also visible on non-detached remotes), leading to 000... prefixes

  • I don't know what's up with the remote callbacks, maybe !32 (diffs)?

  • there were test failures both before and after the patch:

    FAIL: tests/clone.scm - clone-auth-ssh-credentials FAIL: tests/clone.scm - clone-auth-ssh-agent FAIL: tests/clone.scm - clone-and-fetch-auth-ssh-credentials FAIL: tests/clone.scm - clone + transfer-progress FAIL: tests/proxy.scm - clone with HTTPS proxy

    Maybe related to !31 (closed) (untested)

Merge request reports