AntiFeatures needed for your apps in your F-Droid Repo
I've just downloaded your latest PrrofMode APK (RC-5) from your GitLab releases, as it was not in your repo. As I'm used to do, I ran my library checker over it and found some offenders. Wondering if that's just the GitLab release APK, I also downloaded the latest APK from the Guardian F-Droid repo – same results for RC1:
Offending libs:
---------------
* Play Services SafetyNet (/com/google/android/gms/safetynet): NonFreeDep,NonFreeNet
* Google Mobile Services (/com/google/android/gms): NonFreeDep
2 offenders.
Getting curious, I checked with some other apps. And yes, several hits here as well. Checkey was clean, but Haven has
Offending libs:
---------------
* Google Mobile Services (/com/google/android/gms): NonFreeDep
1 offenders.
Next, Obscura Cam & Ripple clean but then Save (OpenArchive) with
Offending libs:
---------------
* Dropbox Core SDK for Java (/com/dropbox/core): NonFreeNet
* Play Services SafetyNet (/com/google/android/gms/safetynet): NonFreeDep,NonFreeNet
* Google Mobile Services (/com/google/android/gms): NonFreeDep
* ACRA (/org/acra): Tracking
4 offenders.
Finally, the latest Tor Browser Alpha:
Offending libs:
---------------
* Adjust Android SDK (/com/adjust/sdk): Tracking
* Play Install Referrer Library (/com/android/installreferrer): NonFreeDep,NonFreeNet,Tracking
* Firebase Data Transport (/com/google/android/datatransport): NonFreeNet
* Android Market (/com/google/android/finsky): NonFreeNet
* Google Cloud Messaging (/com/google/android/gms/cloudmessaging): NonFreeDep,NonFreeNet
* Google Mobile Services (/com/google/android/gms): NonFreeDep
* Google Play Core (/com/google/android/play/core): NonFreeNet,NonFreeDep
* Firebase (/com/google/firebase): NonFreeNet,NonFreeDep
* Firebase Analytics (/com/google/firebase/analytics): NonFreeDep,Tracking
* Firebase Installations (/com/google/firebase/installations): NonFreeNet
* Sentry SDK for Java (/io/sentry): Tracking
11 offenders.
Some of them might be "false positives", granted – that should then be pointed out in the app description maybe (other folks might check the apps as well and wonder). For the "real ones", at least AntiFeatures should be set accordingly. I'm not sure if the Guardian Repo has set the same inclusion criteria as F-Droid or is rather closer to my repo, but in the former case those NonFreeDep (GMS, FCM & Co) should not even be there; for FCM eg. you could consider switching to UnifiedPush.
@eighthave can you please take a look, as discussed?