Normal-mode analysis with vsites or shells works for first molecule of each type only - Redmine #2720
The routine get_atom_index in mtop_util.cpp works for only one molecule at a time. The routine is used for normal mode analysis with vsites or shells and for analysis of the result using gmx nmeig.
(from redmine: issue id 2720, created on 2018-10-31 by dspoel, closed on 2018-11-28)
- Relations:
- duplicates #2721 (closed)
- Changesets:
- Revision e9b526ba7cbc1c665535768f70b02bee95b47d38 by David van der Spoel on 2018-11-01T20:30:55Z:
Updated normal modes output for sw-dimer.
Due to a bug in mtop_util.cpp only the first molecule in the
sw-dimer was used in a normal mode analysis. This is fixed in patch
https://gerrit.gromacs.org/#/c/8631/.
Fixed a bug in gmxtest.pl when comparing two xvg files where the
reference value is zero (it computed the relative difference and
divided by zero). This only showed up in the new output file
normal_modes/sw_dimer/eigenfreq.xvg.
Part of #2720
Change-Id: Iae990bbff2c19c28310618f2cadf1157a62242d0
- Revision 4dede5be by David van der Spoel on 2018-11-09T10:37:47Z:
Change get_atom_index to allow multiple molecules.
Make gromacs take into account atoms in all molecules.
This allows Hessian matrix creation to work over all
molecules in a simulation. An update to the regression
tests has been submitted as well.
During fixing of the problem, another problem surfaced in
the normal mode calculations to do with ordering of atoms
which is fixed here as well.
Fixes #2720
Change-Id: I9fc2dd05cb1c67d46b6d4c3d9139e6b3bed72f17