Skip to content

improve gpu_utils-test - Redmine #2405

I added some actual device transfers in some of the “unit” tests here, but that seems to be a bad idea. At least one user had a setup where the whole test binary took 75 seconds to run, and it’s even 7 s on my deskto Szilard noted at the time that the transfers were not needed, but we ran with it because the tests were set up to not use a device if one wasn’t found.

Plus gentoo, debichem and bioconda have found issues with these tests for non-GPU builds, even though I built them to work, and our Jenkins non-GPU builds have been OK.

So I propose

  • we eliminate device transfers from tests for builds that support GPU execution
  • we eliminate most/all of the tests for builds that do not support GPU execution

(from redmine: issue id 2405, created on 2018-02-08 by mark.j.abraham, closed on 2018-03-02)

Use death test only when supported

In build farms for bioconda and DebiChem, some environments don't
support death tests, so hopefully if we use the GoogleTest machinery
to avoid using them when not supported we can avoid issues in such
environments.

Refs #2405

Change-Id: I17efe3b620b162d615b91a5f5cd4c8bd458143a5
  • Revision 8223d564 by Mark Abraham on 2018-02-27T09:14:47Z:
Fix GPU utils test

We should only attempt device-side work when we have compatible GPUs.

Fixes #2405 for CUDA

Change-Id: Idc28c7e89a5f08ee1d19943e3663385f2b23ff44