Skip to content

Remove unused FPE initialization from dot.c

Erwin Janssen requested to merge gh-53405804/1183/ErwinJanssen/remove-fenv-init into master

In cmd/dot/dot.c, non standard floating point exceptions are enabled in a platform specific way in a sequence of ifdefs. However, this is never used because:

  • The rest of the code never checks for set floating point exception flags (with fetestexcept for example).
  • The check that toggles the whole block, ifndef NO_FPERR is almost false. NO_FPERR is always defined on Windows and only disabled on specific platforms that do not support -ffast-math.

In conclusion, the code adds unnecessary complexity and should be removed. Do you agree or am I missing something?

Merge request reports