Skip to content
  • Matthew Fernandez's avatar
    506b7703
    gvpr: fix: when setting subgraph defaults, explicit-ize root graph defaults · 506b7703
    Matthew Fernandez authored
    When setting a subgraph attribute default, the root graph would first be
    consulted to see if it had a registered default. If not, the new default was
    considered something that should be applied to the root graph. It is unclear to
    me why the logic was designed this way and it seems this behavior is counter to
    what users expect. This change prevents this “hoisting” of defaults to the root
    graph by forcing the root graph’s implicit default to first become explicit in
    this scenario.
    
    Gitlab: fixes #2639
    Gitlab: #2578 (comment 2018578508)
    Reported-by: Steve Roush
    506b7703
    gvpr: fix: when setting subgraph defaults, explicit-ize root graph defaults
    Matthew Fernandez authored
    When setting a subgraph attribute default, the root graph would first be
    consulted to see if it had a registered default. If not, the new default was
    considered something that should be applied to the root graph. It is unclear to
    me why the logic was designed this way and it seems this behavior is counter to
    what users expect. This change prevents this “hoisting” of defaults to the root
    graph by forcing the root graph’s implicit default to first become explicit in
    this scenario.
    
    Gitlab: fixes #2639
    Gitlab: #2578 (comment 2018578508)
    Reported-by: Steve Roush
To find the state of this project's repository at the time of any of these versions, check out the tags.
Loading