Skip to content
  • Tom Tromey's avatar
    Add new overload of gdbarch_return_value · 4e1d2f58
    Tom Tromey authored
    The gdbarch "return_value" can't correctly handle variably-sized
    types.  The problem here is that the TYPE_LENGTH of such a type is 0,
    until the type is resolved, which requires reading memory.  However,
    gdbarch_return_value only accepts a buffer as an out parameter.
    
    Fixing this requires letting the implementation of the gdbarch method
    resolve the type and return a value -- that is, both the contents and
    the new type.
    
    After an attempt at this, I realized I wouldn't be able to correctly
    update all implementations (there are ~80) of this method.  So,
    instead, this patch adds a new method that falls back to the current
    method, and it updates gdb to only call the new method.  This way it's
    possible to incrementally convert the architectures that I am able to
    test.
    
    
    4e1d2f58