pkcs11: Fix macro REPEAT_ON_INVALID_HANDLE

Tim Rühsenrequested to merge
rockdaboot/fix-repeat-on-invalid-handle into master
  • pkcs11: Fix macro REPEAT_ON_INVALID_HANDLE

The macro REPEAT_ON_INVALID_HANDLE contained a return, which did not do cleanups like freeing memory or unlocking mutexes. This leads to memory leaks and even deadlocks under certain error conditions.

Signed-off-by: Tim Rühsen tim.ruehsen@gmx.de

Checklist

  • Commits have Signed-off-by: with name/author being identical to the commit author
  • Code modified for feature
  • Test suite updated with functionality tests
  • Test suite updated with negative tests
  • Documentation updated / NEWS entry present (for non-trivial changes)

Reviewer's checklist:

  • Any issues marked for closing are addressed
  • There is a test suite reasonably covering new functionality or modifications
  • Function naming, parameters, return values, types, etc., are consistent and according to CONTRIBUTION.md
  • This feature/change has adequate documentation added
  • No obvious mistakes in the code
Edited by Alexander Sosedkin

Merge request reports