Skip to content

compress-cert: don't send bad_certificate alert manually

Daiki Ueno requested to merge dueno/gnutls:wip/dueno/compress-cert-fixes into master

The library API is not designed to proactively send alert by itself, but it is rather a responsibility of the application to decide to which alert to be sent when. This removes the manual call to gnutls_alert_send in the code handling TLS 1.3 Certificate message when a decompression error happens.

Checklist

  • Commits have Signed-off-by: with name/author being identical to the commit author
  • Code modified for feature
  • Test suite updated with functionality tests
  • Test suite updated with negative tests
  • Documentation updated / NEWS entry present (for non-trivial changes)
  • CI timeout is 2h or higher (see Settings/CICD/General pipelines/Timeout)

Reviewer's checklist:

  • Any issues marked for closing are addressed
  • There is a test suite reasonably covering new functionality or modifications
  • Function naming, parameters, return values, types, etc., are consistent and according to CONTRIBUTION.md
  • This feature/change has adequate documentation added
  • No obvious mistakes in the code
Edited by Zoltán Fridrich

Merge request reports