Skip to content

Fixed DHE params output in gnutls-cli-debug

Ramesh Adhikari requested to merge SilentSobs/gnutls:dhe-params-stdout into master

Fixing Issue #13 This commit addresses an issue where gnutls-cli-debug was emitting Diffie-Hellman Ephemeral (DHE) parameters to a statically-named file (debug-dh.out) when run with the --verbose option. This behavior posed a potential security risk, as it could inadvertently create files in directories where arbitrary file creation could have unintended side effects.

To mitigate this issue, the behavior has been modified such that DHE parameters are now directed to stdout/stderr by default. Additionally, users have the option to specify a file path using the --dhparams-out=str argument to save the parameters to a file if desired.

This change improves security by ensuring that DHE parameters are handled safely, while still providing users with the flexibility to save them to a file if needed.

  • Fixed DHE params output in gnutls-cli-debug

Signed-off-by: Ramesh Adhikari adhikari.resume@gmail.com

Checklist

  • [*] Commits have Signed-off-by: with name/author being identical to the commit author
  • [*] Code modified for feature
  • [*] Test suite updated with functionality tests
  • [*] Test suite updated with negative tests
  • [] Documentation updated / NEWS entry present (for non-trivial changes)
  • CI timeout is 2h or higher (see Settings/CICD/General pipelines/Timeout)

Reviewer's checklist:

  • Any issues marked for closing are addressed
  • There is a test suite reasonably covering new functionality or modifications
  • Function naming, parameters, return values, types, etc., are consistent and according to CONTRIBUTION.md
  • This feature/change has adequate documentation added
  • [*] No obvious mistakes in the code
Edited by Ramesh Adhikari

Merge request reports