Skip to content

tests: ignore SIGPIPE in forking tests if the parent is TLS client

Daiki Ueno requested to merge dueno/gnutls:wip/dueno/sigpipe into master

If the tests are forking and the parent process is a client, care must be taken to handle SIGPIPE reported by the child process (server) when the client closes the connection.

This hadn't been exposed until commit dd79ac9b, thanks to the fact that the parent process kept the other pipe end which effectively prevented a "broken pipe".

Checklist

  • Commits have Signed-off-by: with name/author being identical to the commit author
  • Code modified for feature
  • Test suite updated with functionality tests
  • Test suite updated with negative tests
  • Documentation updated / NEWS entry present (for non-trivial changes)
  • CI timeout is 2h or higher (see Settings/CICD/General pipelines/Timeout)

Reviewer's checklist:

  • Any issues marked for closing are addressed
  • There is a test suite reasonably covering new functionality or modifications
  • Function naming, parameters, return values, types, etc., are consistent and according to CONTRIBUTION.md
  • This feature/change has adequate documentation added
  • No obvious mistakes in the code

Merge request reports