Skip to content
Snippets Groups Projects

build: disable TLS heartbeat extension by default

Merged Daiki Ueno requested to merge dueno/gnutls:wip/dueno/disable-heartbeat into master

The heartbeat extension in TLS (RFC 6520) is not widely used given other implementations dropped support for it. This makes it disabled by default, though the users are able to enable it back with the --enable-heartbeat-support configure option.

Fixes: #743 (closed)

Checklist

  • Commits have Signed-off-by: with name/author being identical to the commit author
  • Code modified for feature
  • Test suite updated with functionality tests
  • Test suite updated with negative tests
  • Documentation updated / NEWS entry present (for non-trivial changes)
  • CI timeout is 2h or higher (see Settings/CICD/General pipelines/Timeout)

Reviewer's checklist:

  • Any issues marked for closing are addressed
  • There is a test suite reasonably covering new functionality or modifications
  • Function naming, parameters, return values, types, etc., are consistent and according to CONTRIBUTION.md
  • This feature/change has adequate documentation added
  • No obvious mistakes in the code
Edited by Zoltán Fridrich

Merge request reports

Pipeline #726393574 passed

Pipeline passed for ad1231aa on dueno:wip/dueno/disable-heartbeat

Merged by Daiki UenoDaiki Ueno 2 years ago (Dec 19, 2022 1:39pm UTC)

Loading

Pipeline #726673571 failed

Pipeline failed for 358bbdd1 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading